Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CDN assets from theme. #86

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Removing CDN assets from theme. #86

merged 2 commits into from
Dec 24, 2023

Conversation

samueleresca
Copy link
Member

Related to #84:

  • Removed static assets from theme as will be moved to incubator-pekko-site
  • Keep relative URLs (i.e.: assets/stylesheets/pekko-theme.css) as they are automatically resolved as https://hostname/assets/stylesheets/pekko-theme.css

Required changes: apache/pekko-site#49

Copy link
Contributor

@pjfanning pjfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning
Copy link
Contributor

pjfanning commented Dec 22, 2023

One thing is that we'll make testing doc changes to repos like https://github.com/apache/incubator-pekko harder.

Today, if you run sbt paradoxBrowse, it will build the docs into target/paradox/main/site and you can load up the index.html page from there and the CSS, etc. will be found. In theory, users could copy the missing files into target/paradox/main/site themselves or we could script something.

In the end, it might be easier if we don't rely on relative paths and hardcode that we can get the static files from explicit URLs. We could make the hostname of these URLs configurable. Default to https://pekko.apache.org but users could set https://pekko.staged.apache.org.

@samueleresca
Copy link
Member Author

One thing is that we'll make testing doc changes to repos like https://github.com/apache/incubator-pekko harder.

Today, if you run sbt paradoxBrowse, it will build the docs into target/paradox/main/site and you can load up the index.html page from there and the CSS, etc. will be found. In theory, users could copy the missing files into target/paradox/main/site themselves or we could script something.

In the end, it might be easier if we don't rely on relative paths and hardcode that we can get the static files from explicit URLs. We could make the hostname of these URLs configurable. Default to https://pekko.apache.org but users could set https://pekko.staged.apache.org.
@pjfanning
I have added the assets.hostname variable for handling the hostname. Default is configured to https://pekko.apache.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants